Add language-specific linting and shellcheck to format.sh - #5689
Merged
Merged
Conversation
Contributor
|
|
bm1549
commented
Nov 10, 2025
Contributor
Author
There was a problem hiding this comment.
This came from running npm install; npm ci would fail otherwise
| local e | ||
| for e; do [[ "${e}" == "${needle}" ]] && return 0; done | ||
|
|
||
| # shellcheck disable=SC2053 # explicitly allow glob matching |
Contributor
Author
There was a problem hiding this comment.
Needed glob matching to ignore *node_modules*, otherwise this fails locally if you've installed any of them before
cbeauchesne
requested changes
Nov 10, 2025
cbeauchesne
approved these changes
Nov 10, 2025
Contributor
Author
|
Test failure are unrelated - going to bypass merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#5684 failed linting in CI, although
format.shpassed locallyChanges
This PR introduces npm checks (when installed) and shellcheck into
format.shto more easily identify these issues before a PR is openedWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present